[Xen-devel] Re: [PATCH 03/15] xen: Add a new target to qemu: target-xen

[Anthony Liguori <anthony@xxxxxxxxxxxxx>]

On 08/12/2010 09:09 AM, stefano.stabellini@xxxxxxxxxxxxx wrote:
> From: Anthony PERARD<anthony.perard@xxxxxxxxxx>
>
> This patch adds a new Xen device model target to Qemu, called
> target-xen.
>    
A xen specific target is definitely the wrong approach.

I understand the desire to avoid the TCG code.  We would like to 
(optionally) do the same in KVM.
The right way to do this though is to make it possible to build without 
TCG by wrapping the common interfaces in a function pointer table.

> diff --git a/target-xen/exec-dm.c b/target-xen/exec-dm.c
> new file mode 100644
> index 0000000..3d64695
> --- /dev/null
> +++ b/target-xen/exec-dm.c
>    
This takes a non-target specific file and makes it target specific.  
This is not a reasonable approach.  What's the issue with the existing 
exec.c?
Regards,

Anthony Liguori

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel