Re: [Xen-devel] [PATCH] libxc: make unlock_page return error

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Christoph Egger writes ("[Xen-devel] [PATCH] libxc: make unlock_page return 
error"):
> As a result of debugging 'xend segfaults when starting',
> the attached patch makes unlock_pages return an error.

Having read this in more detail, it seems that you're making
{lock,unlock}_pages return errno values on error.  That's fine but
it's quite unusual in libxc; all libxc functions normally return -1 on
error and set errno.

So I think the unusual return value convention is worth a comment in
xc_private.h.  Can you please resubmit with such a comment ?

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel