[Xen-devel] Re: [PATCH,v2] xl: randomly generate UUID's

[Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>]

On Fri, 2010-08-20 at 16:44 +0100, Christoph Egger wrote:
> On Friday 20 August 2010 17:09:59 Gianni Tedesco wrote:
> > On Mon, 2010-08-16 at 16:05 +0100, Christoph Egger wrote:
> > > On Monday 16 August 2010 16:48:56 Gianni Tedesco wrote:
> > > > This patch converts xl to randomly generate UUID's rather than using a
> > > > dodgy time-seeded PRNG. I have incorporated Cristoph Eggers suggestions
> > > > wrt. portability so I would be grateful for an ACK on the NetBSD side
> > > > of things. This also folds in the "v2: xl: make libxl_uuid2string
> > > > internal to libxenlight" patch since it couldn't be avoided in fixing
> > > > up xl printfs() which grok around in the uuid type directly.
> > > >
> > > > I have ignored various suggestions so far on auto-generation of MAC
> > > > addresses and left it as a topic for a future patch to solve. In other
> > > > words the behaviour stays the same it's just using a true random
> > > > source.
> > > >
> > > > This will probably conflict horribly with "libxl: autogenerate type
> > > > definitions and destructor functions" so if it's acked in principle I
> > > > can re-base and re-send on top of that.
> > >
> > > Please do. The patch looks almost good to me - see line comments -
> > > I would like to compile-test it at least on NetBSD before acknowledging
> > > the patch.
> > >
> > > Christoph
> > >
> > > > Signed-off-by: Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>
> > > >
> > > > diff -r 85bd0f6e8fed tools/libxl/Makefile
> > > > --- a/tools/libxl/Makefile      Fri Aug 13 13:55:51 2010 +0100
> > > > +++ b/tools/libxl/Makefile      Mon Aug 16 15:39:13 2010 +0100
> > > > @@ -16,6 +16,9 @@ CFLAGS += -I. -fPIC
> > > >  CFLAGS += $(CFLAGS_libxenctrl) $(CFLAGS_libxenguest)
> > > > $(CFLAGS_libxenstore) $(CFLAGS_libblktapctl)
> > > >
> > > >  LIBS = $(LDLIBS_libxenctrl) $(LDLIBS_libxenguest)
> > > > $(LDLIBS_libxenstore) $(LDLIBS_libblktapctl) $(UTIL_LIBS)
> > > > +ifeq ($(CONFIG_Linux),y)
> > > > +LIBS += -luuid
> > > > +endif
> > >
> > > This is not needed because $(UTIL_LIBS) already covers that case.
> >
> > Not sure what you mean by this, if I omit that linen the I get link
> > errors. That's the way it's done in tools/blktap2/ and I just copied
> > that.
> 
> Oh, sorry. I mixed up -lutil with -luuid and thought we have UUID_LIBS.
> Maybe we should add to config/StdGNU.mk
> 
>     UUID_LIBS = -luuid
> 
> and to config/NetBSD.mk
> 
>     UUID_LIBS =
> 
> and then use $(UUID_LIBS).
> 
> Christoph

Sounds reasonable

> > Am about to re-base and re-send this patch so please clarify if this is
> > indeed wrong for some reason.

Your suggestion would work just fine as a clean up patch on top of this
I think.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel