Re: [Xen-devel] [PATCH] xl: improve vif2 parsing

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Fri, 20 Aug 2010, Gianni Tedesco (3P) wrote:
> To be honest I am not that concerned about length of xl_cmdimpl.c since
> most of xl is straightfoward "parse a bit of config, pass results to a
> libxl call" - but libxl.c could probably use splitting up to make it
> easier to understand the subsystems within it. Splitting up
> create_domain() is probably most urgent task in xl_cmdimpl.c.

Yes, create_domain should be refactored and some code should be move to
libxl: we cannot expect all the possible libxl callers to replicate the
complexity of create_domain.


> Coding style / 80 char limit is a bit of a bummer but not sure how the
> maintainers will feel about coding style patches. Probably be OK.
> 

I would be happy to apply code style patches, however I have to say that
greater than 80 chars lines don't bother me.

> > Btw. I saw that cpuid= is still missing in libxl, I have a version 
> > improved over the clumsy xm interface 90% ready, but will probably not 
> > able to send it out still this week.
> 
> Yes, please patch and post. Also another thing is that 'uuid =' in the
> config file is ignored. That's on my wishlist :)
> 
> I always look forward to seeing more patches.
> 
 
ditto


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel