Re: [Xen-devel] [PATCH, v3]: xl: randomly generate UUID's

[Christoph Egger <Christoph.Egger@xxxxxxx>]

On Thursday 26 August 2010 14:02:35 Christoph Egger wrote:
> On Wednesday 25 August 2010 20:38:25 Gianni Tedesco wrote:
> > On Fri, 2010-08-20 at 16:50 +0100, Christoph Egger wrote:
> > > On Friday 20 August 2010 17:15:21 Gianni Tedesco wrote:
> > > > Changes since last time:
> > > >  - Re-based to remove orthogonal concern of UUID string formatting
> > > > fixed in 22001:0b6f82eaaea9 "xl: make libxl_uuid2string internal to
> > > > libxenlight" - Incorporated Christoph Egger's suggestions
> > >
> > > I will give this patch a try next week.
> > > Christoph
> >
> > *ping* - any news? I think it's straightforward so should be good to go.
>
> I'm about reworking the pieces that don't compile. That is mainly
> the use of LIBXL_UUID_FMT causing warnings like
> 'subscripted value is neither array nor pointer'.

Ok, here we go. The patch is against changeset 22068:3c4c3d48a835
and is not ready yet though, it needs to also
fix build for tools/ocaml/libs/xl/xl_stubs.c.

The build fails with
xl_stubs.c:143: error: subscripted value is neither array nor pointer.

I think using libxl_uuid_from_string() should do it but I'm not familiar
with oxenstored.

I am not sure if the use of malloc() in libxl_uuid2string() is correct,
someone familiar with the garbage collector please fix it.

Due to the mentioned caveats, I don't acknowledge this patch.
Nonetheless, I am sending the patch out to not thwart Gianni to do his
development work.
I want to re-test another version of this patch.

Christoph


-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

Attachment: xen_tools_libxluuid.diff
Description: Text Data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel