[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH 1/2] xl: add cpuid parameter
On Fri, 2010-08-27 at 13:56 +0100, Andre Przywara wrote: > diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c > index 099d82e..da9c7fd 100644 > --- a/tools/libxl/libxl.c > +++ b/tools/libxl/libxl.c > @@ -98,6 +98,20 @@ void > libxl_key_value_list_destroy(libxl_key_value_list kvl) > free(kvl); > } > > +void libxl_cpuid_destroy(libxl_cpuid_type *cpuid) > +{ > + int i, j; > + > + if (cpuid == NULL) > + return; > + for (i = 0; cpuid[i].input[0] != XEN_CPUID_INPUT_UNUSED; i++) { > + for (j = 0; j < 4; j++) > + if (cpuid[i].policy[j] != NULL) > + free(cpuid[i].policy[j]); > + } > + free(cpuid); > +} This can be auto-generated. Also libxl_*_destroy() functions never call free on the passed pointer. Hence ending _destroy() rather than _free(). _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |