Re: [Xen-devel] [PATCH 3/7] vtpm Mini-Os domain: mini-os defines

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Wed, 25 Aug 2010, Samuel Thibault wrote:
> The principle is probably useful indeed.
> 
> Matthew Fioravante, le Wed 25 Aug 2010 11:15:04 -0400, a ??crit :
> > This patch adds some #defines to mini-os
> > NO_BLKFRONT
> 
> I tend to frown upon "negative" flags, as they're less readable. I know
> that using "positive" will require adding them to all other stubdom
> projects, but it's probably still better that way: we'll realize for
> instance that pv-grub doesn't actually need pcifront :)
> 
 
I agree, also all those ifdef's make the code difficult to read.
Wouldn't it be possible to enable/disable the compilation of those files
altogether and provide stubs for the export functions instead?

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel