Re: [Xen-devel] Re: [PATCH] libxl: fix xenstore connection when run in domU

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2010-08-31 at 10:05 +0100, Jun Zhu (Intern) wrote:
> Hi
> 
> There are other places that use the xs_daemon_open in libxl. Is it necessory 
> to change them as follows?
>      ctx->xsh = xs_daemon_open();
> +    if (!ctx->xsh)
> +        ctx->xsh = xs_domain_open();
>      if (!ctx->xsh) {
>          XL_LOG_ERRNOVAL(ctx, XL_LOG_ERROR, errno, 
>                          "cannot connect to xenstore");

I think we'd be better off introducing "libxl__xs_open" which does the
right thing and make the users to all use it.

Is there any harm in always preferring xs_domain_open, even if the
xenstore daemon happens to be co-located in the same domain?

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel