[Xen-devel] Re: [PATCH]: xl: introduce xlu_cfg_get_(string|long)_default

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Gianni Tedesco writes ("Re: [PATCH]: xl: introduce 
xlu_cfg_get_(string|long)_default"):
> I had considered that approach first but then discarded it because it
> was hard to tell which values had been set or not, eg. if a boolean
> option had been set to 0 by an explicit config entry or due to initial
> memset() - meaning that you wouldn't know whether to override it with a
> default or not. IOW we would need a bitmap or something to keep track.

Yes.  Either a bitmap for which values are valid, or a convention that
booleans are ints which are given -1 or +1 values, or something.

> Perhaps a higher level API would be better:
...
>     {.type = STR, .u.str = {&dm_info.vnclisten, "127.0.0.1"}, },

Urgh, that's overly complicated, I think.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel