[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] RE: [Xen-devel] [PATCH] qemu-xen: fix cpu hotplug
On Fri, 3 Sep 2010, Liu, Jinsong wrote: > Christoph Egger wrote: > > On Friday 03 September 2010 08:28:53 Liu, Jinsong wrote: > >> Ian Jackson wrote: > >>> Stefano Stabellini writes ("[Xen-devel] [PATCH] qemu-xen: fix cpu > >>> > >>> hotplug"): > >>>> qemu-xen: fix cpu hotplug > >>>> > >>>> The current xenstore watch path for a vcpu-set event is wrong and > >>>> is also wrong the code to parse it. This patch fixes both of them: > >>> > >>> Thanks. So it seems you're saying it's completely broken in > >>> xen-unstable. > >> > >> Stabellini, I read your attached patch, it's OK. > >> In fact, we firstly implemented xenstore watch by same scheme of your > >> patch, watching each cpu node status: > >> /local/domain/xx/cpu/yy/availability=offline (online) > >> > >> However, we finally didn't use this scheme. We watch 'common' node > >> instead: /local/domain/xx/cpu in this way, only 1 watch point need. > >> Considering vcpu number may become more and more in the future (say, > >> more than 128), it's more simple and reasonable. (Watches can be set > >> at points in the hierarchy and an individual watch will be triggered > >> when anything at or below that point in the hierachy changes) > > > > Does this scheme allow to say how many cores per cpu exist ? > > > > When you run a Windows guest with a license for one cpu socket, > > then you can use 4 cores. But if one cpu is equal to one socket, > > then you can't use SMP for the Windows guest. > > > > Christoph > > > > Seems this is another story? > Yes, the scheme we are talking about regards the communication of vcpu online and offline to qemu and nothing else. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |