RE: [Xen-devel] [PATCH 06/16] vmx: nest: handling VMX instruction exits

["Dong, Eddie" <eddie.dong@xxxxxxxxx>]

Qing He wrote:
> add a VMX instruction decoder and handle simple VMX instructions
> except vmlaunch/vmresume and invept
> 
> Signed-off-by: Qing He <qing.he@xxxxxxxxx>
> Signed-off-by: Eddie Dong <eddie.dong@xxxxxxxxx>
> 
> ---
> 

> +static int __clear_current_vvmcs(struct vmx_nest_struct *nest)
> +{
> +    int rc;
> +
> +    if ( nest->svmcs )
> +        __vmpclear(virt_to_maddr(nest->svmcs));
> +
> +#if !CONFIG_VVMCS_MAPPING
> +    rc = hvm_copy_to_guest_phys(nest->gvmcs_pa, nest->vvmcs,


Qing:
        Why this may be failure? The only reason may be nest->gvmcs_pa, but I 
guess we already verified the address.

Thx, Eddie

> PAGE_SIZE); +    if ( rc != HVMCOPY_okay )
> +        return X86EMUL_EXCEPTION;
> +#endif
> +
> +    nest->vmcs_valid = 0;
> +
> +    return X86EMUL_OKAY;
> +}
> +
> +/*

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel