[Xen-devel] [PATCH]: xl: fix double free of domain names

[Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>]

Assigning malloc'd variables from one structure to another when both of
them are free'd via destructors is a bad idea. Let's use a strdup.

Signed-off-by: Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>

diff -r ef2d0a9b2036 tools/libxl/xl_cmdimpl.c
--- a/tools/libxl/xl_cmdimpl.c  Fri Sep 10 14:59:29 2010 +0100
+++ b/tools/libxl/xl_cmdimpl.c  Fri Sep 10 15:10:32 2010 +0100
@@ -296,7 +296,7 @@ static void init_dm_info(libxl_device_mo
 
     libxl_uuid_generate(&dm_info->uuid);
 
-    dm_info->dom_name = c_info->name;
+    dm_info->dom_name = strdup(c_info->name);
     dm_info->device_model = strdup("qemu-dm");
     dm_info->videoram = b_info->video_memkb / 1024;
     dm_info->apic = b_info->u.hvm.apic;



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel