[Xen-devel] [PATCH]: xl: don't leak a lot of memory in forked process in domain_create

[Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>]

A goto statement skips over freeing data structures for no good reason.
It's not a real issue since the next step is to exit() but this cleans
up output of valgrind so that other leaks and errors can be spotted.

Signed-off-by: Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>

diff -r c7c2bc8d6b3a tools/libxl/xl_cmdimpl.c
--- a/tools/libxl/xl_cmdimpl.c  Fri Sep 10 15:20:33 2010 +0100
+++ b/tools/libxl/xl_cmdimpl.c  Fri Sep 10 15:35:02 2010 +0100
@@ -1511,7 +1511,7 @@ start:
                 goto error_out;
             }
             ret = domid;
-            goto waitpid_out;
+            goto out;
         }
 
         rc = libxl_ctx_postfork(&ctx);



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel