Re: [Xen-devel] [Patch][resend] implementation of cpupool support in xl

[Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>]

On 09/15/10 12:22, Ian Campbell wrote:
> On Wed, 2010-09-15 at 10:37 +0100, Ian Campbell wrote:
> > On Wed, 2010-09-15 at 10:23 +0100, Juergen Gross wrote:
> > > And I'm not sure I'll get the generating of the bindings correctly.
> > > So yes, please do it!
> > Will do.
> >
> > > From looking at your patch it seems that the intention is that the size
> > is the number of bytes in the map, rather than the number of CPUs which
> > can be represented or the number of uint64_t's, is that right and/or
> > what you would like to use?
> Seems like libxc counts bytes but libxl (with your patch) counts 64 bit
> words.
>
> There doesn't seem to be any users of the size currently so I went with
> bytes in the below (compile tested + examined generated code only) but
> since your patch adds the first actual user feel free to change it if
> that makes the libxl interface more suitable for your needs or whatever.
Thanks, updated patch is attached.
I didn't add the destructor, because this would have made things much more
complicated as libxl_list_pool returns an array of libxl_poolinfo elements.
Doing only one free() at caller side is much easier than cycling through
the elements and free-ing all extra allocated cpumaps.


Juergen

--
Juergen Gross                 Principal Developer Operating Systems
TSP ES&S SWE OS6                       Telephone: +49 (0) 89 3222 2967
Fujitsu Technology Solutions              e-mail: juergen.gross@xxxxxxxxxxxxxx
Domagkstr. 28                           Internet: ts.fujitsu.com
D-80807 Muenchen                 Company details: ts.fujitsu.com/imprint.html

Attachment: xl-pools.patch
Description: Text Data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel