RE: [Xen-devel] [PATCH 04/16] vmx: nest: nested control structure

["Dong, Eddie" <eddie.dong@xxxxxxxxx>]

>>>>>  #ifdef __x86_64__
>>>>>      struct vmx_msr_state msr_state;
>>>>>      unsigned long        shadow_gs;
>>>> 
>>>> I think, the structure should be allocated in the
>>>> nestedhvm_vcpu_initialise() function hook and assigned to the
>>>> nh_arch pointer in struct nestedhvm.
>>> 
>>> Well, the structure itself is pretty small, so dynamic allocation is
>>> really not a good idea.
> 
> It's not a question of size. The point is that it is opaque to
> non-vmx code. 

I think it is anyway recycling again, that is not necessary.
Outside of VMX should not access those VMX specific code in theory. If it needs 
some parameters, vcpu can stand for all of them.

Thx, Eddie
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel