RE: [Xen-devel] [PATCH V4] libxl: make libxl communicate with xenstored by socket or xenbus driver

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("RE: [Xen-devel] [PATCH V4] libxl: make libxl communicate 
with xenstored by socket or xenbus driver"):
> On Tue, 2010-09-14 at 17:27 +0100, Ian Jackson wrote:
> > Then the right answer is to make it take a ctx parameter, surely ?
> 
> gc->owner contains the surrounding context, doesn't it?

Yes.  So passing a gc to libxl__xs_open would be just as good (better
probably, for consistency).  Jun Zhu's libxl__xs_open took neither.

> > And ensure that during initialisation, the logging is initialised
> > before the xenstore connection.)
> 
> This seems to be the case in libxl_ctx_init().

I thought it would be; I'm trying to help Jun out by pointing out the
things that need to be checked when preparing this patch.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel