Re: [Xen-devel] [patch] Xen build - Debian vs Redhat layout patch options

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Bruce Edge writes ("Re: [Xen-devel] [patch] Xen build - Debian vs Redhat layout 
patch options"):
> OK, resubmit #3 with Olaf's suggestion.
> No other changes.

Thanks.  Nearly there I think...

There are still a couple of occurrences of this:

> +# See DISTRO_TYPE in the docs

which should presumably refer to docs/misc/distro_mapping.txt.


> +CONFIG_LEAF_DIR  | /sysconfig       | /default      | /sysconfig     |
                      ^                  ^               ^

Not hugely important, but these slashes should be omitted I think ?
Since CONFIG_LEAF_DIR is used and defined like this:

> +SYSCONFIG_DIR = $(CONFIG_DIR)/$(CONFIG_LEAF_DIR)
...
> +CONFIG_LEAF_DIR ?= sysconfig


> +To add support for new distributions that don't use the above locations,
> +one must grep for the above elements and add appropriate checks.

Surely this should simply say that for a new distro one must change
the settings for the appropriate values, in Config.mk, and/or set them
in a local ".config" file.  There shouldn't be any need to grep for
them, should there ?


> -080630 modifications to support SUSE-based and debian-based guests
> +080630 modifications to support SUSE-based

This can be removed now ?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel