Re: [Xen-devel] [PATCH v2 01/10] xen: remap GSIs as pirqs when running as initial domain

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Wed, 6 Oct 2010, Konrad Rzeszutek Wilk wrote:
> > > > +void __init xen_setup_pirqs(void)
> > > > +{
> > > > +       int irq;
> > > > +#ifndef CONFIG_SMP
> > > > +       int nr_ioapics = 1;
> > > > +#endif
> > > 
> > > Should this be defined in a header instead? Was this nr_ioapics==1
> > > meant to fall in the '0 == nr_ioapics' to setup the first sixteen
> > > irqs?
> > > 
> > > Is CONFIG_X86_IO_APIC more appropiate than CONFIG_SMP?
> > 
> > I think it was supposed to fix a compilation error in case
> > CONFIG_X86_IO_APIC is not set, so that in both cases in which an ioapic
> > is not present in the system or the ioapic support is not compiled in
> > the kernel we would fall in the '0 == nr_ioapics' code path.
> 
> That is what I thought, but nr_ioapics is set to one, so how do
> we fall in 0 == 1 code path?
> 
 
that was another mistake, I have fixed it now


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel