[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH]: correctly generate dependencies for gdbsx



gdbsx hacks CFLAGS to remove optimisations for easier debugging, however
this breaks dep generation due to an early evaluation of CFLAGS and
leaves stale files called "..d" after a make clean. We could possibly
fix this by separating dep generation from the rest of CFLAGS but it
seems a little invasive. The gdbsx hackers can do their own thing during
development and testing anyway...

Signed-off-by: Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>

diff -r 2e8bdff60d01 tools/debugger/gdbsx/Rules.mk
--- a/tools/debugger/gdbsx/Rules.mk     Sun Oct 24 13:18:26 2010 +0100
+++ b/tools/debugger/gdbsx/Rules.mk     Mon Oct 25 17:37:53 2010 +0100
@@ -2,8 +2,3 @@ include $(XEN_ROOT)/tools/Rules.mk
 
 CFLAGS   += -Werror -Wmissing-prototypes 
 # (gcc 4.3x and later)   -Wconversion -Wno-sign-conversion
-
-# just in case have to debug gdbsx, keep life simple.
-TMPFLAGS := $(CFLAGS)
-CFLAGS := $(filter-out -O% -DNDEBUG -fomit-frame-pointer, $(TMPFLAGS))
-CFLAGS += -O0
diff -r 2e8bdff60d01 tools/debugger/gdbsx/gx/Makefile
--- a/tools/debugger/gdbsx/gx/Makefile  Sun Oct 24 13:18:26 2010 +0100
+++ b/tools/debugger/gdbsx/gx/Makefile  Mon Oct 25 17:37:53 2010 +0100
@@ -9,7 +9,7 @@ all: gx_all.a
 
 .PHONY: clean
 clean:
-       rm -rf gx_all.a *.o 
+       rm -rf gx_all.a *.o .*.d
 
 
 #%.o: %.c $(GX_HDRS) Makefile
diff -r 2e8bdff60d01 tools/debugger/gdbsx/xg/Makefile
--- a/tools/debugger/gdbsx/xg/Makefile  Sun Oct 24 13:18:26 2010 +0100
+++ b/tools/debugger/gdbsx/xg/Makefile  Mon Oct 25 17:37:53 2010 +0100
@@ -32,5 +32,5 @@ xen-headers:
 
 .PHONY: clean
 clean:
-       rm -rf xen xg_all.a $(XG_OBJS) 
+       rm -rf xen xg_all.a $(XG_OBJS)  .*.d
 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.