Re: [Xen-devel] [PATCH 2/2] hvmloader->rombios use C/H/S, LBA when have been set by qemu

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

DuanZhenzhong writes ("[Xen-devel] [PATCH 2/2] hvmloader->rombios use C/H/S, 
LBA when have been set by qemu"):
> This is due to some ide state pointer in ide.c is NULL.

How did the pointer become null ?  I think the bug has happened
earlier and that your patch is therefore not correct.

For example,

> static inline void ide_set_irq(IDEState *s)
> {
> -    BMDMAState *bm = s->bmdma;
> -    if (!s->bs) return; /* ouch! (see ide_flush_cb) */
> +    BMDMAState *bm;
> +    if (!s || !s->bs) return; /* ouch! (see ide_flush_cb) */

I think it is always wrong to call ide_set_irq(NULL).

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel