Xen project Mailing List

Re: [Xen-devel] [PATCH] X86: Prefer TSC-deadline timer in Xen

To: Tim Deegan <Tim.Deegan@xxxxxxxxxx>, "Wei, Gang" <gang.wei@xxxxxxxxx>

From: Keir Fraser <keir@xxxxxxx>

Date: Thu, 28 Oct 2010 15:42:02 +0100

Cc: "Brown, Len" <len.brown@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxxxx>

Delivery-date: Thu, 28 Oct 2010 07:42:57 -0700

Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=m4K1R5izPemxZ1RFxf9reofpABqjWgqhNWRkR1NJUTDzHAb24RiFhdgBTYwXYljzXt wC7bNnBApuvzYN4qNmsP9iVHL7ISqgmi5wHEyk6jsV1X3XSqHdD83zpfQ52azj56iZbR +UnCysZUi4Eq9k5MBEuaDBIqDqzlLx4nEZFPs=

List-id: Xen developer discussion <xen-devel.lists.xensource.com>

Thread-index: Act2rkhTPsjL5Xw19EeHmxsnnnUi/Q==

Thread-topic: [Xen-devel] [PATCH] X86: Prefer TSC-deadline timer in Xen

On 28/10/2010 15:22, "Tim Deegan" <Tim.Deegan@xxxxxxxxxx> wrote: >> I still want to keep them because __setup_APIC_LVTT() will be called >> multiple times - the first call with tdt_enabled == false, and the >> following calls with tdt_enabled == true. > > Is that important? If so, please add explanatory comments in the > appropriate places, because it's not obvious that it's happening, or why. Indeed, I often simplify patches when I merge them, and an apparently redundant foo_enabled variable would be first to go. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel

©2013 Xen Project, A Linux Foundation Collaborative Project. All Rights Reserved.
Linux Foundation is a registered trademark of The Linux Foundation.
Xen Project is a trademark of The Linux Foundation.