Re: [Xen-devel] [PATCH] libxc, ia64: ia64 counter part of 22275:e95dc0eb152d and 22285:36a317494429

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

KUWAMURA Shin'ya writes ("[Xen-devel] [PATCH] libxc, ia64: ia64 counter part of 
22275:e95dc0eb152d and 22285:36a317494429"):
> This patch fixes compilation errors by 22275:e95dc0eb152d:
>   ia64/xc_ia64_linux_save.c:797: error: too few arguments to function 
> 'callbacks->switch_qemu_logdirty'
> and applies 22285:36a317494429 to ia64.

Thanks, I have applied this patch.

If I may make an observation: much of ia64/xc_ia64_linux_save.c is
identical to xc_domain_save.c.  This kind of clone-and-hack is
precisely likely to lead to the kind of problems we see here, where
changes and subsequent fixes are made to one copy of the code but not,
or not properly, to the other.

It might be worth trying to reconcile these two versions so that there
is less needless ia64-specific code.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel