Re: [Xen-devel] [PATCH] qemu/block-vvfat.c: fix warnings with _FORTIFY_SOURCE

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Olaf Hering writes ("[Xen-devel] [PATCH] qemu/block-vvfat.c: fix warnings with 
_FORTIFY_SOURCE"):
> In function 'snprintf',
>     inlined from 'init_directories' at block-vvfat.c:868:10,
>     inlined from 'vvfat_open' at block-vvfat.c:1065:24:
> /usr/include/bits/stdio2.h:65:3: warning: call to __builtin___snprintf_chk 
> will always overflow destination buffer

Thanks, I have applied both of these patches to qemu-xen-unstable.

However: have you checked whether these problems exist in qemu
upstream ?  With Anthony's work on upstreaming Xen support in qemu
coming along well, we should be thinking about sending fixes like this
upstream.

When we switch to the upstream-based qemu we won't want to carry a lot
of patches like this one.

Regards,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel