[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [Patch] Adding back CPUID support for Xsave


  • To: Haitao Shan <maillists.shan@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Keir Fraser <keir@xxxxxxx>
  • Date: Tue, 09 Nov 2010 08:52:47 +0000
  • Cc:
  • Delivery-date: Tue, 09 Nov 2010 00:53:40 -0800
  • Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:user-agent:date:subject:from:to:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=RMO6QxTwXsNVM3nFDiYhn7qFfjOTND6X9MWI2cbHRyhqpam8NJ515fEvIBcVqWuGcg SlkOYyWKB1VyTu+rjnJPxwu3qpAdXFmHPdkzUL8sc+7wtLP7g0s73azlegXTXTxlm690 mrIxZ7uIuLtlh4F6gswrmbg1cNG0VAmrWLjlw=
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: Act/63shgKEUbP26A0qRgoFjMmm6Dg==
  • Thread-topic: [Xen-devel] [Patch] Adding back CPUID support for Xsave

Thanks, this looks better. I have some further questions however.

You appear to only be exposing XSAVE to PV guests -- Why is that?

Also, the patch passes the AVX feature unconditionally through to HVM guests
-- firstly, why only visible HVM guests; and secondly, should it not be
conditional on XSAVE support in the hypervisor (don't we need XSAVE to be
able to save/restore AVX state)?

 -- Keir

On 09/11/2010 02:31, "Haitao Shan" <maillists.shan@xxxxxxxxx> wrote:

> Hi, Keir,
> 
> This patch adds back the reverted CPUID support for XSAVE feature. Can
> you have a review?
> 
> Signed-off-by: Shan Haitao <haitao.shan@xxxxxxxxx>
> 
> Shan Haitao
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.