Re: [Xen-devel] [PATCH] xend: drbd improvements

[Jim Fehlig <jfehlig@xxxxxxxxxx>]

Ian Jackson wrote:
> Jim Fehlig writes ("[Xen-devel] [PATCH] xend: drbd improvements"):
>   
>> xend: drbd improvements
>>
>> 1) drbdadm state is debrecated, and the script tries to detect the
>> primary/secondary information from the deprecated message
>> 2) os.popen2 does not work with the array as argument
>> 3) popen2 is deprecated since python2.6
>>     
>
> Forgive my ignorance, but: why does xend need to mess with drbd at
> all ?  Why can't it just open the block device ?
>   

Good question.  I too was surprised to see special casing of drbd within
xend.  Seems c/s 20158 added this code to allow bootloaders (pygrub,
domUloader, et. al.) to work with drbd devices using the 'drbd:resource'
syntax.  Perhaps the author of that patch (cc'd) can provide more
details.  This patch simply makes improvements to the existing code. 
BTW, c/s 20158 also uses popen2() in tools/python/xen/util/blkif.py, so
IMO a V2 will be needed if this patch is considered.

> xl and libxl don't have any drbd functionality so if this is necessary
> it's a missing feature.
>   

Micheal, does xl/libxl need this functionality?

Regards,
Jim


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel