Re: [Xen-devel] [PATCH] stubdom: allow building with read-only sources

[Patrick Colp <pjcolp@xxxxxxxxx>]

On 11 November 2010 00:45, Jan Beulich <JBeulich@xxxxxxxxxx> wrote:
>>>> On 10.11.10 at 20:09, Patrick Colp <pjcolp@xxxxxxxxx> wrote:
>>> Â--- a/stubdom/Makefile
>>> +++ b/stubdom/Makefile
>>> @@ -155,8 +175,9 @@ cross-libpci: $(LIBPCI_STAMPFILE)
>>> Â$(LIBPCI_STAMPFILE): pciutils-$(XEN_TARGET_ARCH) $(NEWLIB_STAMPFILE)
>> $(ZLIB_STAMPFILE)
>>> Â Â Â Â( cd $< && \
>>> Â Â Â Â Âcp ../libpci.config.h lib/config.h && \
>>> + Â Â Â Â chmod u+w lib/config.h && \
>>> Â Â Â Â Âecho '#define PCILIB_VERSION "$(LIBPCI_VERSION)"' >> lib/config.h 
>>> && \
>>> - Â Â Â Â cp ../libpci.config.mak lib/config.mk && \
>>> + Â Â Â Â ln -sf ../../libpci.config.mak lib/config.mk && \
>>
>> Should the above line be
>>
>> Â+ Â Â Â Â ln -sf ../libpci.config.mak lib/config.mk && \
>>
>> instead? It seems an extra ../ was added and based just on the patch I
>> can't tell why.
>
> No - the difference is between referencing the real file (cp) and
> creating a relative (to the target's location) symlink.

Ah right, of course :)


Patrick

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel