[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Xen-devel] Re: [PATCH 06/20] x86/ticketlock: make __ticket_spin_trylock common
- To: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
- From: AmÃrico Wang <xiyou.wangcong@xxxxxxxxx>
- Date: Sat, 13 Nov 2010 18:17:32 +0800
- Cc: Nick Piggin <npiggin@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Srivatsa Vaddagiri <vatsa@xxxxxxxxxxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxxxx>, Linux Virtualization <virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx>, Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>, Avi Kivity <avi@xxxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>
- Delivery-date: Mon, 15 Nov 2010 01:22:47 -0800
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=xAQjf6LmAPEUeBIWLO58TkLIR8TtEEJHaC2e0yW+gMywGLIXY0qnAX6U2Y4PabFKi6 2PXoj+5mOocgxFjXCCLTWCw0EjW9R6P6R1OPmwBa78g3rNckko3EKmmgD6q8jgxEuaDM HS4V2bXAJTy86vjptSS8UEVZvkImLse2mSND4=
- List-id: Xen developer discussion <xen-devel.lists.xensource.com>
On Wed, Nov 03, 2010 at 10:59:47AM -0400, Jeremy Fitzhardinge wrote:
>+ union {
>+ struct __raw_tickets tickets;
>+ __ticketpair_t slock;
>+ } tmp, new;
>+ int ret;
>+
>+ tmp.tickets = ACCESS_ONCE(lock->tickets);
>+ if (tmp.tickets.head != tmp.tickets.tail)
>+ return 0;
>+
>+ new.slock = tmp.slock + (1 << TICKET_SHIFT);
>+
>+ ret = cmpxchg(&lock->ticketpair, tmp.slock, new.slock) == tmp.slock;
>+ barrier(); /* just make nothing creeps before lock is
>claimed */
This one should be smp_wmb(), right? No CONFIG_X86_OOSTORE protected.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|