[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] linux-2.6.18/evtchn: clear secondary CPUs' cpu_evtchn_mask[] after restore


  • To: Jeremy Fitzhardinge <jeremy@xxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxxxx>
  • From: Keir Fraser <keir@xxxxxxx>
  • Date: Tue, 16 Nov 2010 07:42:10 +0000
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Mon, 15 Nov 2010 23:43:29 -0800
  • Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=tKCpsdduecjDqQGzp0lbsy0XSqivq/+MfUkjPKlz8MpxzWazb/YgiGr2SPoeD6bgpF 20LQvcmHNvD0dTFF9bx1BBsWkie0a/AZCwtXvDtqPJDTfMTmH+N/F95Vl3xhRmlYgP+W SHMQaNdM8oGD7QuFUpFvBm0Bgm7rFDK18W9s0=
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AcuFYcaSf3wceW2SYE2M85D3Yz4Mdw==
  • Thread-topic: [Xen-devel] [PATCH] linux-2.6.18/evtchn: clear secondary CPUs' cpu_evtchn_mask[] after restore

On 16/11/2010 01:28, "Jeremy Fitzhardinge" <jeremy@xxxxxxxx> wrote:

> On 11/15/2010 08:56 AM, Jan Beulich wrote:

>> memset(cpu_evtchn, 0, sizeof(cpu_evtchn));
>> - memset(cpu_evtchn_mask[0], ~0, sizeof(cpu_evtchn_mask[0]));
>> + for_each_possible_cpu(i)
>> +  memset(cpu_evtchn_mask[i], -!i, sizeof(cpu_evtchn_mask[i]));
> 
> -!i?  Really?  Golf-clap and all, but I think something a bit more
> explicit would be better ;)

I'm going to clarify that bit when I apply to 2.6.18. :-)

 -- Keir

>     J
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.