Xen project Mailing List

Re: [Xen-devel] [PATCH 10/13] Nested Virtualization: interrupts (svm specific)

To: Tim Deegan <Tim.Deegan@xxxxxxxxxx>, Christoph Egger <Christoph.Egger@xxxxxxx>

From: Keir Fraser <keir@xxxxxxx>

Date: Tue, 16 Nov 2010 15:45:52 +0000

Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>

Delivery-date: Tue, 16 Nov 2010 07:46:37 -0800

Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=m3d+B0pS/CPI0aucAdwIrF2Lqv0fdEy1rHK2f4+N0qxZCrITPNnEmLbOnFDoiRbvFM dcSoYrghN2qjd/FAtB58p2oV4yFqw5Ie9zkF/ZoFzFRkREmTYQq8fjnkuuEaN3/SS/dk xASVzeErP/JgZgAts56pDsnpUFbW5A/3XUV8Q=

List-id: Xen developer discussion <xen-devel.lists.xensource.com>

Thread-index: AcuFpVkI12GEf6TbyEe4Fi5f6Wi6TQ==

Thread-topic: [Xen-devel] [PATCH 10/13] Nested Virtualization: interrupts (svm specific)

On 16/11/2010 15:06, "Tim Deegan" <Tim.Deegan@xxxxxxxxxx> wrote: >> +static int >> +nestedsvm_vcpu_clgi(struct vcpu *v) >> +{ >> + struct nestedsvm *svm = &vcpu_nestedsvm(v); >> + >> + /* clear gif flag */ >> + svm->ns_gif = 0; >> + local_event_delivery_disable(); /* mask events for PV drivers */ > > This function, and the stgi one below, can only operate safely on > current; if you want to keep the argument for performance then maybe > ASSERT(v == current) for sanity. I don't believe in the performance win. Functions which act correctly only on current should not be passed a vcpu parameter. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel

©2013 Xen Project, A Linux Foundation Collaborative Project. All Rights Reserved.
Linux Foundation is a registered trademark of The Linux Foundation.
Xen Project is a trademark of The Linux Foundation.