[Xen-devel] wrong vmexit size in xenalyze

[Olaf Hering <olaf@xxxxxxxxx>]

George,

what is the reason behind this changeset?
http://xenbits.xensource.com/ext/xenalyze.hg?rev/9fa7e4d2a3af

All my vmexit trace entries have size 4 for 64bit and 3 for 32bit.
Looking at the code in ./xen/arch/x86/hvm/vmx/vmx.c, HVMTRACE_ND() gets
size 3 for VMEXIT64. But HVMTRACE_ND does a 'sizeof(u32)*count+1' in
xen-4.0. 
The xen-unstable macro looks different. It was changed in this revision:

 # 8 weeks ago:    x86/hvm: fix extra size passed to __trace_var()
 # revision 10:    9cebb977e9d8 (diff) (annotate)
 # author:         Keir Fraser <keir.fraser@xxxxxxxxxx>
 # date:   Mon Sep 20 18:53:18 2010 +0100

I think this means most of the extra_words checks are bogus now, unless
the same change also goes into the 4.0 branch.

What should we do about this difference in tracedata?


Olaf

--- a/xenalyze.c        Wed Nov 10 14:56:56 2010 +0000
+++ b/xenalyze.c        Wed Nov 10 14:58:31 2010 +0000
@@ -4828,8 +4828,8 @@ void hvm_vmexit_process(struct record_in
         };
     } *r;
 
-    if(ri->extra_words != 4
-       && ri->extra_words != 3
+    if(ri->extra_words != 3
+       && ri->extra_words != 2
         )
     {
         fprintf(warn, "FATAL: vmexit has unexpected extra words %d!\n",


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel