Re: [Xen-devel] [PATCH] hvm passthru: Fix a xen-unstable crash

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Mon, 29 Nov 2010, Wei Wang2 wrote:
> On Monday 29 November 2010 16:49:05 Stefano Stabellini wrote:
> > On Mon, 29 Nov 2010, Keir Fraser wrote:
> > > Stefano,
> > >
> > > Can you ack/nack this patch please.
> >
> > ack.
> >
> > I think we also need this:
> >
> >
> > diff -r 79b71c77907b xen/arch/x86/physdev.c
> > --- a/xen/arch/x86/physdev.c        Wed Nov 24 10:20:03 2010 +0000
> > +++ b/xen/arch/x86/physdev.c        Mon Nov 29 15:26:03 2010 +0000
> > @@ -236,7 +236,8 @@ static int physdev_unmap_pirq(struct phy
> >          spin_lock(&d->event_lock);
> >          ret = unmap_domain_pirq_emuirq(d, unmap->pirq);
> >          spin_unlock(&d->event_lock);
> > -        goto free_domain;
> > +        if ( unmap->domid == DOMID_SELF || ret )
> > +            goto free_domain;
> >      }
> >
> >      ret = -EPERM;
> >
> >
> > Wei, could you give it a try, in addition to your patch?
> >
> > Thanks,
> >
> > Stefano
> 
> Hi Stefano,
> This patch works well together with my patch on our testing system. No more 
> crashes.

Thanks!
Keir, can you please apply both patches?

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel