Re: [Xen-devel] PVops domain 0 crash on NUMA system only Node==1 present (Was: Re: Bug#603632: linux-image-2.6.32-5-xen-amd64: Linux kernel 2.6.32/xen/amd64 booting fine on bare metal, but not as dom0 with Xen 4.0.1 (Dell R410))

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2010-12-03 at 08:52 +0000, Ian Campbell wrote:
> 
> > IanC: it looks like passing a node id of "-1" is the correct way to
> > say "I don't care". 
> 
> I thought so too but convinced myself from staring at the code that it
> wouldn't work in this case -- I'll double check before I resubmit. 

I was mislead because node gets placed verbatim into desc->node which at
first glance seemed invalid but on second look it seems to be fine,
everything which reads that value is prepared to accept the -1. There is
precedent for using -1 in hpet_assign_irq, although most other places
seem to use numa_node_id().

I've tested with -1 and it seems ok. I see (too late) that you've
already made the change so I guess you knew this ;-)

Are you going to put this change into next-2.6.32 as well as 37?

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel