Re: [Xen-devel] [PATCH 4 of 4] Support new xl command cpupool-numa-split

[Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>]

On 12/08/10 14:12, Ian Campbell wrote:
> On Wed, 2010-12-08 at 12:20 +0000, Juergen Gross wrote:
> > On 12/08/10 12:16, Ian Campbell wrote:
> > > Can this loop be merged with the preceding loop, with the body being the
> > > else case of the if?
> > No. I have to add new cpus first to avoid a cpupool without cpus in between.
> ok.
>
> I was thinking that because this function only gets here if there is a
> single pool that all CPUs must be in that pool -- but that's not
> actually true is it? Even if that were the common case there's nothing
> to enforce that.
Perhaps I should add a comment to avoid a problem later...

> > > Do we want to rename Pool-0 at some point too or do we rely on that name
> > > elsewhere?
> > Good question. There is a hard coded "Pool-0" reference in libxl, but this
> > could easily be changed.
> > I'm not sure about implications in xm/xend. I'll check this.
> I don't think there is a particularly strong requirement to allow xend
> and xl to coexist. I'd recommend just leaving xend doing what it does
> today and fix xl/libxl only.
Okay, I'll modify xl to rename Pool-0 to Pool-node[n].


Juergen

--
Juergen Gross                 Principal Developer Operating Systems
TSP ES&S SWE OS6                       Telephone: +49 (0) 89 3222 2967
Fujitsu Technology Solutions              e-mail: juergen.gross@xxxxxxxxxxxxxx
Domagkstr. 28                           Internet: ts.fujitsu.com
D-80807 Muenchen                 Company details: ts.fujitsu.com/imprint.html

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel