Re: [Xen-devel] [PATCH 1 of 5] Support getting topology info in libxl

[Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>]

On Thu, 2010-12-09 at 12:39 +0000, Juergen Gross wrote:
> 
> +PyObject *attrib__libxl_cpuarray_get(libxl_cpuarray *pptr)
> +{
> +    PyObject *list = NULL;
> +    int i;
> +
> +    list = PyList_New(0);
> +    for (i = 0; i < pptr->entries; i++) {
> +        if (pptr->array[i] == LIBXL_CPUARRAY_INVALID_ENTRY) {
> +            PyList_Append(list, Py_None);
> +            Py_INCREF(Py_None); 


Actually I think I am the one who is confused. It is the other way
around. I need to fix other places that leak references due to this.

IOW, this was good to go first time around, tried to respond earlier but
my mail client barfed the message.

Sorry for the noise! :(

Gianni


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel