Re: [Xen-devel] [PATCH] xen : Replace hard coded domain_id checks with a macro

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2010-12-10 at 07:07 +0000, Mihir Nanavati wrote:
> Replace a number of checks for Dom0, that have been hard coded to
> check for domain_id being zero with a macro is_dom0_domain().

Is the intention for this macro return true for some domid != 0 under
some future circumstance? In that case the macro name will turn out to
be badly chosen.

I'm not sure there is any benefit to hard coding a 0 in the function
name as opposed to hardcoding at the call site. I suppose it's a little
easier to search and replace...

Is there a name which describes the actual semantics which the callers
want, as opposed to testing the dom0-ness? Or perhaps there is more than
one desired semantic, in which case multiple predicates would be ok
IMHO. Does the existing IS_PRIV cover some of the cases?

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel