Re: [Xen-devel] [PATCH] do_memory_op: cleanup if copy_to_guest fails

[Olaf Hering <olaf@xxxxxxxxx>]

On Thu, Dec 16, Keir Fraser wrote:

> Leaving a bit of a mess on failed copy_to_guest is okay imo, as that is
> usually a pretty fatal sign anyway. If there were good reason for cleaning
> up better, we should at least be doing if (test_and_clear(PGC_allocated))
> put_page().

Yes, it would leak just a page and from what I have seen, the Linux
drivers will BUG() most of the time anyway if the hypercall fails.
So I will drop this from my series.

Olaf


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel