[Xen-devel] Re: [PATCH] netback for upstream

[Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>]

On Fri, 2010-12-17 at 16:35 +0000, Jeremy Fitzhardinge wrote:
> On 12/17/2010 03:00 AM, Ian Campbell wrote:
> > I have rebased the current xen/next-2.6.32 netback stuff onto 2.6.37-rc5
> > in a new branch at:
> >   git://xenbits.xen.org/people/ianc/linux-2.6.git 
> > upstream/dom0/backend/netback
> > This builds on my upstream/dom0/backend/core branch. (full pull request
> > style details are at the end)
> >
> > I've added some proper commit messages to the early commits which were
> > previously lacking them. In particular 8495d90cf5c3..5f7b85f2899e seem
> > to have been Authored by Jeremy (according to the git metadata) but were
> > not signed-off. Jeremy is it OK to add your sign-off to those three?
> 
> I'm pretty sure they were yours originally and I lost the authorship
> when importing from mq -> git.

ok. I'll fix that up.

> > Until those early commit messages are done the branch will be subject to
> > rebasing.
> >
> > As it stands the branch won't work because it still needs PageForeign.
> > My intention is to replace this dependency with the new m2p overlay
> > grant table map stuff added for gntdev.
> >
> > In the meantime if you need something right now I do have a working (if
> > somewhat over-engineered) version which removed the dependency of
> > PageForeign by always copying. This is in the
> > upstream/dom0/backend/netback-copying branch in the same repository. I
> > intend to throw this away when I've got the new m2p overlay stuff ready.
> 
> Would it make sense to develop the m2p overlay version on top of the
> copying branch and drop the foreign code altogether?  It makes logical
> sense to go from simple -> more optimised within one history?

The copying version has it's own set of complexity though, and did
involve rewriting/reinventing a bunch of stuff. I'm not sure it is worth
it since the m2p overlay version looks like it would just undo most of
it to get back to a more foreign page like version.

I'll see, I've got the basic code written for the m2p overlay case
already, just need to stop it crashing now ;-)

> > If you wanted the old PageForeign style thing you could look in
> > notupstream/foreign-memory while flagellating yourself.
> 
> Thanks, but no.

;-)

> > Dongxiao Xu (6):
> >       xen/netback: use smart polling instead of event notification
> >       xen/netback: Move global/static variables into struct xen_netbk.
> >       xen/netback: Introduce a new struct type page_ext.
> >       xen/netback: Multiple tasklets support.
> >       xen/netback: Use Kernel thread to replace the tasklet.
> >       Netback: Set allocated memory to zero from vmalloc.
> 
> I think we should drop the smartpoll stuff.  It is still unfixed, and I
> have never pushed it into upstream netfront.

Hmm, yes. Will do.

> Is the tasklet work is independent of that though?

Yes.

[...]
> I can see a definite need for some folding there.

I could do a little but I'd quite like to retain the overall history --
it's useful to be able to track what has come from where in the future.

> I guess it would be a good time to add Paul's other patches?

I was holding off until the baseline was done. If you want to add them
to the 2.6.32 branch I was planning to do a catchup/resync when I've got
the basics upstreamble anyway.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel