[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] {PATCH] Add p2m_lock in set_shared_p2m_entry


  • To: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Jui-Hao Chiang <juihaochiang@xxxxxxxxx>
  • Date: Thu, 23 Dec 2010 08:45:08 +0800
  • Delivery-date: Wed, 22 Dec 2010 16:46:01 -0800
  • Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type; b=YY/qIdIU5H14VMgBx18Ho996xCzxTtkS755zj7w/eXpPjCE47PYA3eMGXhvf9CYtVU K6Tii0NUIZVJgQgBlgcSFoHPJNPRdxput/cOPLuNtU7sO8eahklD15E5UIr7I5SiBNHf iT2YYn++PcYeC9/f/cfFnUav2sGwfXdVXsLI8=
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>

Without the lock, set_shared_p2m_entry() will BUG when xen is compiled with debug=y

Singed-off-by: Jui-Hao Chiang <juihaochiang <at> gmail.com>

--- a/xen/arch/x86/mm/p2m.c    Tue Dec 21 18:10:46 2010 +0000
+++ b/xen/arch/x86/mm/p2m.c    Thu Dec 23 16:40:41 2010 +0800
@@ -2665,7 +2665,9 @@ set_shared_p2m_entry(struct p2m_domain *
     set_gpfn_from_mfn(mfn_x(omfn), INVALID_M2P_ENTRY);
 
     P2M_DEBUG("set shared %lx %lx\n", gfn, mfn_x(mfn));
+    p2m_lock(p2m);
     rc = set_p2m_entry(p2m, gfn, mfn, 0, p2m_ram_shared);
+    p2m_unlock(p2m);
     if ( 0 == rc )
         gdprintk(XENLOG_ERR,
             "set_mmio_p2m_entry: set_p2m_entry failed! mfn=%08lx\n"
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.