Re: [Xen-devel] [PATCH 3 of 5] mem_access: public interface changes

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

I didn't review the whole series I just happened to notice this while
reviewing the use of hypercall buffers in libxc:

 On Wed, 2010-12-29 at 07:27 +0000, Joe Epstein wrote:
> +struct xen_hvm_set_mem_access {

The definition of this structure needs to come along with the first use
of it, which in this case would be the 1/5 patch which adds the
hypercall.

Similarly for any other interface changes etc. You need the code changes
to be with the interface changes, or otherwise to construct your patch
series such that you add the new interface, convert everything to it and
then remove the old interface.

Otherwise everything is broken mid-way through the series, it should
compile and work at each step/patch.

It also makes review hard since each patch doesn't really stand alone.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel