Re: [Xen-devel] [PATCH] libxl: Lists qdisk device in libxl_device_disk_list

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

anthony.perard@xxxxxxxxxx writes ("[Xen-devel] [PATCH] libxl: Lists qdisk 
device in libxl_device_disk_list"):
> As libxl switch to qdisk when blktap isn't available, this patch makes
> libxl_device_disk_list also list qdisk device. So
> libxl_build_device_model_args_new will be able to add qdisk device to
> the command line options of Qemu.

Thanks for this contribution.  But what you have done is introduced
yet a third copy of a section of code which has been cloned-and-hacked
one already.

Can you please make a patch which breaks the common code out into a
separate function, or macro, or uses a loop, or something ?  I don't
much mind how it's done but to my mind a function is probably going to
be easiest.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel