[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] {PATCH] Add p2m_lock in set_shared_p2m_entry
- To: Tim Deegan <Tim.Deegan@xxxxxxxxxx>
- From: Jui-Hao Chiang <juihaochiang@xxxxxxxxx>
- Date: Thu, 6 Jan 2011 22:52:30 +0800
- Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 06 Jan 2011 06:53:19 -0800
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=kg4oY/qKMNuQO6mfdiy3bmQPPG0URsJktc+v0rBNCHgY1Em7uyM69mAnw5YjkOGQdU 8NAd+DpFyZx+FvLUQMFiNyNfsTi+NnJm9Wb7qvhEU9M2vT9CunSXf9bQHUHUs9YR3vX4 OE4DLLB91ziE+o7lfTqhNfc81+TXagBNBHGfc=
- List-id: Xen developer discussion <xen-devel.lists.xensource.com>
Hi, Tim
Thanks. I'll have to make a slightly more complex fix, as
set_shared_p2m_entry() can be called (via p2m_teardown() and
mem_sharing_unshare_page()) with the p2m lock already held. :(
Actually our original problem is the mem_sharing_share_pages() doesn't hold the p2m lock when calling set_shared_p2m_entry(), which causes the share operation to die.
That's a sign of a deeper illness which will probably lead to deadlocks
elsewhere. I intend to give the MM locking (p2m, shadow, hap, log-dirty
and page-sharing locks) a good kicking some time soon, maybe after 4.1
is released.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
