[Xen-devel] Re: [PATCH] mem_sharing: fix race condition of nominate and unshare

[Tim Deegan <Tim.Deegan@xxxxxxxxxx>]

At 06:02 +0000 on 07 Jan (1294380120), Jui-Hao Chiang wrote:
> One of the solution is to
> (a) Simply replace shr_lock with p2m_lock.

I think this is the best choice.   If we find that the p2m lock is a
bottleneck we can address it later. 

Cheers,

Tim

> (b) In unshare(), apply the following: if (!p2m_locked_by_me(p2m)) call 
> p2m_lock, otherwise, don't lock it.
> (c) p2m_change_type() and set_shared_p2m_entry() are pretty similar, we can 
> merge the functionality into one function, which does NOT take p2m_lock, and 
> keep the original p2m_change_type() unchanged.
> 
> Correct me if wrong.
> 
> Bests,
> Jui-Hao

-- 
Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Principal Software Engineer, Xen Platform Team
Citrix Systems UK Ltd.  (Company #02937203, SL9 0BG)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel