Re: [Xen-devel] [PATCH]: minios: eliminate compile warning - use of uninitialised variable

[Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>]

On Fri, 2011-01-07 at 19:27 +0000, Samuel Thibault wrote:
> Gianni Tedesco, le Fri 07 Jan 2011 17:21:59 +0000, a Ãcrit :
> > On Fri, 2011-01-07 at 16:58 +0000, Samuel Thibault wrote:
> > > Gianni Tedesco, le Fri 07 Jan 2011 16:52:49 +0000, a Ãcrit :
> > > > I'm not sure if this is a legit catch by gcc or a false positive due to
> > > > extra cleverness in gcc-4.5. Either way it causes the build to barf.
> > > 
> > > It seems a false positive to me. What is the warning message?
> > 
> > lib/math.c:197:22: error: âtmp.ul[1]â may be used uninitialized in this 
> > function
> > lib/math.c:153:11: note: âtmp.ul[1]â was declared here
> > 
> > I figured it was a false positive but looking at it now, maybe not?
> 
> Oooh, is this perhaps on a 64bit machine? There is actually a bug: these
> should be ints, not longs... Use this instead.
> 
> Samuel
> 
> Replace long/int/short sizes with proper exact-size types for 64bit
> architectures.
> 
> Signed-off-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>
> 
> diff -r a33886146b45 extras/mini-os/lib/math.c
> --- a/extras/mini-os/lib/math.c       Fri Oct 08 11:41:57 2010 +0100
> +++ b/extras/mini-os/lib/math.c       Fri Jan 07 20:26:34 2011 +0100

Yep, works for me...

Gianni


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel