[Xen-devel] Re: [PATCH] xl: save domain config (userdata) under correct domid/uuid

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

I wrote:
> I think this is fixed by the patch below, which I have just applied.

Um, but, I missed a bit.

# HG changeset patch
# User Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
# Date 1294882004 0
# Node ID ce208811f5401dcc6dc39a1e592b102e8d3e7c85
# Parent  d839631b604807fe0f978f9eacc1c73f6a9bf0bd
xl: correct test for domid on error exit from domain_create

The previous changeset 22739:d839631b6048 changed the initialisation
of domid without changing the corresponding cleanup test.  Oops.

Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

diff -r d839631b6048 -r ce208811f540 tools/libxl/xl_cmdimpl.c
--- a/tools/libxl/xl_cmdimpl.c  Thu Jan 13 00:18:35 2011 +0000
+++ b/tools/libxl/xl_cmdimpl.c  Thu Jan 13 01:26:44 2011 +0000
@@ -1627,7 +1627,7 @@ start:
 
 error_out:
     release_lock();
-    if (domid)
+    if (domid > 0)
         libxl_domain_destroy(&ctx, domid, 0);
 
 out:

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel