[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [Xen-devel] [PATCH] qemu: fix use after free
Commit 99d53fbb69d3e03be61ae10506a304a3d08d792f introduced this, and the compiler indirectly warned about it. The patch is only compile tested (I don't even know how to reproduce the original problem), but I suppose worth applying regardless. Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx> Cc: Chun Yan Liu <cyliu@xxxxxxxxxx> --- a/keymaps.c +++ b/keymaps.c @@ -56,15 +56,12 @@ typedef struct { static void del_key_range(struct key_range **krp, int code) { struct key_range *kr; - struct key_range *kr_pr; - for (kr = *krp; kr; kr_pr = kr, kr = kr->next) { + while ((kr = *krp) != NULL) { if (code >= kr->start && code <= kr->end) { - if (kr == *krp) - *krp = kr->next; - else - kr_pr->next = kr->next; + *krp = kr->next; qemu_free(kr); - } + } else + krp = &kr->next; } } Attachment:
qemu-fix-7433.patch _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |