Re: [Xen-devel] [PATCH] xl: Check for dependencies in xl

[Kamala Narasimhan <kamala.narasimhan@xxxxxxxxx>]

> You mean "libxl_ctx_init would always be..."?
>

Yes, sorry.

> In that case yes since that it is the function contains opens the
> connection to xenstore so it must be called first. A libxl user
> shouldn't need to see or use xenstore directly itself since libxl
> encapsulates this.
>
> xtl_createlogger_stdiostream does/can not use xenstore since it comes
> from libxc which is beneath (or perhaps alongside) libxenstore in the
> software stack.
>
>> 2)  There aren't likely to be other dependency checks to be added in
>> future that might warrant a separate function to perform such checks?
>
> It's not clear what other checks there will end up being but those which
> are due to libxl's dependencies (e.g. xenstore) should be in a libxl
> function. This could be a separate libxl_check_dependencies() but I
> can't see any reason not to do it in libxl_ctx_init().
>
> If xl has some dependency of its own independent of libxl which it is
> useful to check then it would be appropriate to add those checks to xl
> itself.
>

Since this toolstack is new to me, as you might have observed from the
previous threads, I didn't differentiate between libxl/xl etc. (in
terms of where the changes end up) while writing those patches and
piling it all up as one unit :)   Now that I understand, I will make
the necessary changes.

Kamala

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel