Re: [Xen-devel] [PATCH] xen: stringify assertion condition for printing sooner

[Keir Fraser <keir@xxxxxxx>]

On 17/01/2011 14:28, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote:

> 
>> diff -r 92e51f0053b5 -r 711cbaa038ca xen/include/xen/lib.h
>> --- a/xen/include/xen/lib.h Mon Jan 17 11:43:46 2011 +0000
>> +++ b/xen/include/xen/lib.h Mon Jan 17 14:12:48 2011 +0000
>> @@ -35,7 +35,7 @@ do {
>>  
>>  #ifndef NDEBUG
>>  #define ASSERT(p) \
>> -    do { if ( unlikely(!(p)) ) assert_failed(p); } while (0)
>> +    do { if ( unlikely(!(p)) ) assert_failed(#p); } while (0)
>>  #else
>>  #define ASSERT(p) ((void)0)
>>  #endif
> 
> But then you should also remove the second stringification in
> include/asm-x86/bug.h:assert_failed(), so that it becomes
> 
> (XEN) Assertion '!in_atomic()' failed at softirq.c:61

I'll give the patch a spin and modify as necessary before I check it in.

 -- Keir

> Jan
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel