Re: [Xen-devel] [PATCH] libxl: fix guest networking

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Christoph Egger writes ("[Xen-devel] [PATCH] libxl: fix guest networking"):
> As previously reported when I start guests with xl then the
> guest network does not work because the qemu-ifup script
> no longer runs.

Thanks, I have applied this patch.  However, two comments:

Firstly, like many of your patches, I had to change the Subject of the
commit message to something more informative.  "fix guest networking"
is rather vague.  You'd make our lives just infinitesimally easier if
you wrote a better subject line yourself :-).

Secondly,

+static const char *libxl_tapif_script(libxl__gc *gc)
+{
+#ifdef __linux__
+    return libxl__strdup(gc, "no");
+#else
+    return libxl__sprintf(gc, "%s/qemu-ifup", libxl_xen_script_dir_path());
+#endif
+}

I'm really not a fan of #ifdefs in the main parts of the code.
Perhaps we can (in 4.2) create a file where we can dump these kind of
things.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel