[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Xen-devel] Re: [PATCH] sched: provide scheduler_ipi() callback in response to smp_send_reschedule()
- To: Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx>
- From: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
- Date: Mon, 17 Jan 2011 12:31:24 +0100
- Cc: linux-m32r-ja@xxxxxxxxxxxxxxxxx, linux-mips@xxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, linux-sh@xxxxxxxxxxxxxxx, Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>, Heiko Carstens <heiko.carstens@xxxxxxxxxx>, "James E.J. Bottomley" <jejb@xxxxxxxxxxxxxxxx>, David Howells <dhowells@xxxxxxxxxx>, Paul Mackerras <paulus@xxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, sparclinux@xxxxxxxxxxxxxxx, Ralf, Linux-Arch <linux-arch@xxxxxxxxxxxxxxx>, Jesper, Mike, Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>, Hirokazu Takata <takata@xxxxxxxxxxxxxx>, x86@xxxxxxxxxx, Koichi, virtualization@xxxxxxxxxxxxxx, Ingo Molnar <mingo@xxxxxxxxxx>, Matt Turner <mattst88@xxxxxxxxx>, Yu <fenghua.yu@xxxxxxxxx>, Frysinger <vapier@xxxxxxxxxx>, user-mode-linux-devel@xxxxxxxxxxxxxxxxxxxxx, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, Jeff Dike <jdike@xxxxxxxxxxx>, linux-alpha@xxxxxxxxxxxxxxx, Nilsson <jesper.nilsson@xxxxxxxx>, Chris Metcalf <cmetcalf@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, Mikael Starvik <starvik@xxxxxxxx>, linux-m32r@xxxxxxxxxxxxxxxxx, Ivan Kokshaysky <ink@xxxxxxxxxxxxxxxxxxxx>, user-mode-linux-user@xxxxxxxxxxxxxxxxxxxxx, uclinux-dist-devel@xxxxxxxxxxxxxxxxxxxx, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, Richard Henderson <rth@xxxxxxxxxxx>, Tony Luck <tony.luck@xxxxxxxxx>, linux-parisc@xxxxxxxxxxxxxxx, linux-cris-kernel@xxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, linux-am33-list@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Baechle <ralf@xxxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Kyle McMartin <kyle@xxxxxxxxxxx>, Paul Mundt <lethal@xxxxxxxxxxxx>, Fenghua, Martin Schwidefsky <schwidefsky@xxxxxxxxxx>, linux390@xxxxxxxxxx, Yasutake <yasutake.koichi@xxxxxxxxxxxxxxxx>, linuxppc-dev@xxxxxxxxxxxxxxxx, Helge Deller <deller@xxxxxx>
- Delivery-date: Tue, 18 Jan 2011 03:21:02 -0800
- List-id: Xen developer discussion <xen-devel.lists.xensource.com>
On Mon, 2011-01-17 at 11:26 +0000, Russell King - ARM Linux wrote:
> On Mon, Jan 17, 2011 at 12:07:13PM +0100, Peter Zijlstra wrote:
> > diff --git a/arch/alpha/kernel/smp.c b/arch/alpha/kernel/smp.c
> > index 42aa078..c4a570b 100644
> > --- a/arch/alpha/kernel/smp.c
> > +++ b/arch/alpha/kernel/smp.c
> > @@ -587,6 +587,7 @@ handle_ipi(struct pt_regs *regs)
> > case IPI_RESCHEDULE:
> > /* Reschedule callback. Everything to be done
> > is done by the interrupt return path. */
> > + scheduler_ipi();
> > break;
> >
> > case IPI_CALL_FUNC:
> > diff --git a/arch/arm/kernel/smp.c b/arch/arm/kernel/smp.c
> > index 9066473..ffde790 100644
> > --- a/arch/arm/kernel/smp.c
> > +++ b/arch/arm/kernel/smp.c
> > @@ -579,6 +579,7 @@ asmlinkage void __exception do_IPI(struct pt_regs *regs)
> > * nothing more to do - eveything is
> > * done on the interrupt return path
> > */
> > + scheduler_ipi();
>
> Maybe remove the comment "everything is done on the interrupt return path"
> as with this function call, that is no longer the case.
>
> Looks like the same is true for Alpha as well?
Right, will do, thanks! It looks like I've somewhat inconsistent with
that.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
