[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] RE: [PATCH][VTD][QUIRK] added quirks for Sandybridge errata workaround, WLAN, VT-d fault escalation


  • To: Jan Beulich <JBeulich@xxxxxxxxxx>
  • From: "Kay, Allen M" <allen.m.kay@xxxxxxxxx>
  • Date: Tue, 18 Jan 2011 16:12:07 -0800
  • Accept-language: en-US
  • Acceptlanguage: en-US
  • Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Keir Fraser <keir@xxxxxxx>
  • Delivery-date: Tue, 18 Jan 2011 16:13:12 -0800
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: Acu29OxhIDRLEHH8QbCnuezi7WB+WAAdycaA
  • Thread-topic: [PATCH][VTD][QUIRK] added quirks for Sandybridge errata workaround, WLAN, VT-d fault escalation

> Isn't there a risk that these MMIO writes interfere with the
> operation of the actual driver running in a domain?

I have checked drivers/gpu/drm/i915/i915_reg.h in the kernel and I don't see 
any usage of these MMIO registers.  Do you think we should add a boot switch to 
allow optionally turn off these workarounds just in case?  If so, what default 
value should it be?

> And even just in Xen itself, how do these writes get
> synchronized? Callers of vtd_ops_preamble_quirk() don't
> appear to be required to hold any particular lock.

I have added a igd_lock in the attached patch.  Can you take a look?

Allen

Attachment: lock.patch
Description: lock.patch

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.